fix(clippy): resolve lints for Rust 1.96 (io_other_error, derivable_impls, manual_contains, unnecessary_sort_by, while_let_loop)

crates/nuwiki-lsp/Cargo.toml

@@ -13,7 +13,7 @@ homepage.workspace = true
 workspace = true
 
 [dependencies]
-nuwiki-core = { path = "../nuwiki-core", version = "0.3.0" }
+nuwiki-core = { path = "../nuwiki-core", version = "0.4.1" }
 tower-lsp = "0.20"
 tokio = { version = "1", features = ["macros", "rt-multi-thread", "io-std", "sync", "fs"] }
 dashmap = "6"

crates/nuwiki-lsp/src/commands.rs

@@ -3762,17 +3762,11 @@ pub mod export_ops {
             .arg("-c")
             .arg(&cmd)
             .status()
-            .map_err(|e| {
-                std::io::Error::new(
-                    std::io::ErrorKind::Other,
-                    format!("custom_wiki2html spawn failed: {e}"),
-                )
-            })?;
+            .map_err(|e| std::io::Error::other(format!("custom_wiki2html spawn failed: {e}")))?;
         if !status.success() {
-            return Err(std::io::Error::new(
-                std::io::ErrorKind::Other,
-                format!("custom_wiki2html exited with {status}"),
-            ));
+            return Err(std::io::Error::other(format!(
+                "custom_wiki2html exited with {status}"
+            )));
         }
         Ok(PageExport {
             page: name.to_string(),
@@ -3821,7 +3815,7 @@ pub mod export_ops {
     /// rendered-HTML body per entry.
     pub fn write_rss(cfg: &WikiConfig, entries: &[DiaryEntry]) -> std::io::Result<PathBuf> {
         let mut sorted: Vec<&DiaryEntry> = entries.iter().collect();
-        sorted.sort_by(|a, b| b.date.cmp(&a.date));
+        sorted.sort_by_key(|a| std::cmp::Reverse(a.date));
         let cap = if cfg.html.rss_max_items == 0 {
             usize::MAX
         } else {

crates/nuwiki-lsp/src/diary.rs

@@ -47,7 +47,7 @@ pub fn list_entries(index: &WorkspaceIndex) -> Vec<DiaryEntry> {
             })
         })
         .collect();
-    out.sort_by(|a, b| a.date.cmp(&b.date));
+    out.sort_by_key(|a| a.date);
     out
 }
 

crates/nuwiki-lsp/src/lib.rs

@@ -406,7 +406,7 @@ impl LanguageServer for Backend {
             .general
             .as_ref()
             .and_then(|g| g.position_encodings.as_ref())
-            .map(|encs| encs.iter().any(|e| *e == PositionEncodingKind::UTF8))
+            .map(|encs| encs.contains(&PositionEncodingKind::UTF8))
             .unwrap_or(false);
         self.use_utf8.store(supports_utf8, Ordering::Relaxed);