Compare commits
2 Commits
7da13ffc5c
...
v0.5.1
| Author | SHA1 | Date | |
|---|---|---|---|
| 2dfc2d9de2 | |||
| 18f1ddfe7f |
Generated
+3
-3
@@ -376,11 +376,11 @@ checksum = "f8ca58f447f06ed17d5fc4043ce1b10dd205e060fb3ce5b979b8ed8e59ff3f79"
|
||||
|
||||
[[package]]
|
||||
name = "nuwiki-core"
|
||||
version = "0.5.0"
|
||||
version = "0.5.1"
|
||||
|
||||
[[package]]
|
||||
name = "nuwiki-ls"
|
||||
version = "0.5.0"
|
||||
version = "0.5.1"
|
||||
dependencies = [
|
||||
"nuwiki-lsp",
|
||||
"tokio",
|
||||
@@ -388,7 +388,7 @@ dependencies = [
|
||||
|
||||
[[package]]
|
||||
name = "nuwiki-lsp"
|
||||
version = "0.5.0"
|
||||
version = "0.5.1"
|
||||
dependencies = [
|
||||
"async-trait",
|
||||
"dashmap 6.1.0",
|
||||
|
||||
+1
-1
@@ -3,7 +3,7 @@ resolver = "2"
|
||||
members = ["crates/*"]
|
||||
|
||||
[workspace.package]
|
||||
version = "0.5.0"
|
||||
version = "0.5.1"
|
||||
edition = "2021"
|
||||
rust-version = "1.83"
|
||||
authors = ["Gabriel Fróes Franco <gffranco@gmail.com>"]
|
||||
|
||||
@@ -617,15 +617,10 @@ impl<'src> LexState<'src> {
|
||||
end -= 1;
|
||||
}
|
||||
|
||||
// Collect cell boundaries.
|
||||
let mut sep_positions = Vec::new();
|
||||
let mut k = i;
|
||||
while k < end {
|
||||
if bytes[k] == b'|' {
|
||||
sep_positions.push(k);
|
||||
}
|
||||
k += 1;
|
||||
}
|
||||
// Collect cell boundaries. A `|` inside a `[[…]]` wiklink, a `{{…}}`
|
||||
// transclusion, or `` `…` `` inline code is literal cell content, not
|
||||
// a separator, so those regions are skipped (see `cell_bar_positions`).
|
||||
let sep_positions = cell_bar_positions(line, i, end);
|
||||
|
||||
if sep_positions.len() < 2 {
|
||||
return false;
|
||||
@@ -1068,6 +1063,51 @@ impl<'src> LexState<'src> {
|
||||
/// bracketed description like `[[page|Task [B-1]]]` keeps the `[B-1]` and closes
|
||||
/// at the final `]]`. A stray single `]` (no matching `[`) is treated as literal
|
||||
/// body text. Returns `None` if no closing `]]` is found.
|
||||
/// Byte offsets of the `|` characters in `line[i..end]` that act as
|
||||
/// table-cell separators. Pipes inside a `[[…]]` wikilink, a `{{…}}`
|
||||
/// transclusion, or `` `…` `` inline code are literal cell content — they
|
||||
/// mirror the regions [`VimwikiLexer::lex_inline`] tokenises as a single unit
|
||||
/// — so they are not reported as separators. An *unclosed* construct is
|
||||
/// treated as a literal opener (it does not start a skip region), so a
|
||||
/// malformed cell can never swallow the rest of the row.
|
||||
///
|
||||
/// Note: a backslash-escaped `\|` is intentionally *not* honoured here,
|
||||
/// because the inline lexer has no escape handling and would render the
|
||||
/// backslash literally; supporting it would need a matching change there.
|
||||
fn cell_bar_positions(line: &str, i: usize, end: usize) -> Vec<usize> {
|
||||
let bytes = line.as_bytes();
|
||||
let mut positions = Vec::new();
|
||||
let mut k = i;
|
||||
while k < end {
|
||||
// These openers are ASCII, so `bytes[k]` never matches a UTF-8
|
||||
// continuation byte and every slice below starts on a char boundary.
|
||||
match bytes[k] {
|
||||
b'[' if bytes.get(k + 1) == Some(&b'[') => {
|
||||
if let Some(close) = find_wikilink_close(&line[k + 2..end]) {
|
||||
k += close + 4; // `[[` + inner + `]]`
|
||||
continue;
|
||||
}
|
||||
}
|
||||
b'{' if bytes.get(k + 1) == Some(&b'{') => {
|
||||
if let Some(close) = line[k + 2..end].find("}}") {
|
||||
k += close + 4; // `{{` + inner + `}}`
|
||||
continue;
|
||||
}
|
||||
}
|
||||
b'`' => {
|
||||
if let Some(close) = line[k + 1..end].find('`') {
|
||||
k += close + 2; // opening + inner + closing backtick
|
||||
continue;
|
||||
}
|
||||
}
|
||||
b'|' => positions.push(k),
|
||||
_ => {}
|
||||
}
|
||||
k += 1;
|
||||
}
|
||||
positions
|
||||
}
|
||||
|
||||
fn find_wikilink_close(s: &str) -> Option<usize> {
|
||||
let b = s.as_bytes();
|
||||
let mut depth: u32 = 0;
|
||||
|
||||
@@ -245,6 +245,19 @@ fn table_with_header_separator() {
|
||||
assert!(out.contains("<td> 1 </td>"));
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn table_cell_with_wikilink_pipe_exports_one_cell() {
|
||||
// Regression: the `|` in `[[url|title]]` must stay inside the link, so the
|
||||
// row keeps two columns and the link renders as a single anchor. Before the
|
||||
// fix the cell split into `[[https://example.com` + `My Site]]`, adding a
|
||||
// phantom <td> and breaking the link.
|
||||
let out = render("| Name | Link |\n|---|---|\n| foo | [[https://example.com|My Site]] |\n");
|
||||
assert!(
|
||||
out.contains("<td> foo </td><td> <a href=\"https://example.com\">My Site</a> </td>"),
|
||||
"got: {out}"
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn single_comment_becomes_html_comment() {
|
||||
let out = render("%% hidden\n");
|
||||
|
||||
@@ -454,6 +454,48 @@ fn table_col_and_row_span_cells() {
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn table_cell_with_wikilink_pipe_is_not_split() {
|
||||
// The `|` inside `[[url|title]]` is part of the link, not a cell
|
||||
// boundary: the row must lex to exactly two cells (three TableSeps).
|
||||
assert_eq!(
|
||||
lex("| foo | [[https://example.com|My Site]] |\n"),
|
||||
vec![
|
||||
TableSep,
|
||||
text(" foo "),
|
||||
TableSep,
|
||||
text(" "),
|
||||
WikiLinkOpen,
|
||||
text("https://example.com"),
|
||||
WikiLinkSep,
|
||||
text("My Site"),
|
||||
WikiLinkClose,
|
||||
text(" "),
|
||||
TableSep,
|
||||
Newline,
|
||||
]
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn table_cell_with_transclusion_and_code_pipes_are_not_split() {
|
||||
// `|` inside `{{…}}` and inside `` `…` `` are both literal.
|
||||
let lexed = lex("| {{a|b}} | `x|y` |\n");
|
||||
let seps = lexed.iter().filter(|t| matches!(t, TableSep)).count();
|
||||
assert_eq!(seps, 3, "expected 2 cells: {lexed:?}");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn table_cell_with_unclosed_wikilink_falls_back_to_pipe_split() {
|
||||
// A malformed, unclosed `[[` must not swallow the rest of the row —
|
||||
// the pipes still delimit cells.
|
||||
let seps = lex("| [[oops | tail |\n")
|
||||
.iter()
|
||||
.filter(|t| matches!(t, TableSep))
|
||||
.count();
|
||||
assert_eq!(seps, 3);
|
||||
}
|
||||
|
||||
// ===== Definition list =====
|
||||
|
||||
#[test]
|
||||
|
||||
@@ -17,5 +17,5 @@ name = "nuwiki-ls"
|
||||
path = "src/main.rs"
|
||||
|
||||
[dependencies]
|
||||
nuwiki-lsp = { path = "../nuwiki-lsp", version = "0.5.0" }
|
||||
nuwiki-lsp = { path = "../nuwiki-lsp", version = "0.5.1" }
|
||||
tokio = { version = "1", features = ["macros", "rt-multi-thread", "io-std"] }
|
||||
|
||||
@@ -13,7 +13,7 @@ homepage.workspace = true
|
||||
workspace = true
|
||||
|
||||
[dependencies]
|
||||
nuwiki-core = { path = "../nuwiki-core", version = "0.5.0" }
|
||||
nuwiki-core = { path = "../nuwiki-core", version = "0.5.1" }
|
||||
tower-lsp = "0.20"
|
||||
tokio = { version = "1", features = ["macros", "rt-multi-thread", "io-std", "sync", "fs"] }
|
||||
dashmap = "6"
|
||||
|
||||
Reference in New Issue
Block a user