From 773bbdb6a6449123ffe0bb078e184f4e7ddd5705 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gabriel=20Fr=C3=B3es=20Franco?= Date: Sun, 31 May 2026 21:34:24 +0000 Subject: [PATCH] docs(gap): record re-audit findings (3 new command gaps + 3 refinements) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Three parallel audits (commands/mappings/configs) re-verified all recent fixes PASS across every context and surfaced new command-attribute gaps, each confirmed against the code: New P3 command gaps: - VimwikiChangeSymbolTo / VimwikiListChangeSymbolI lack -range (upstream has it) → E481 on a visual selection. - VimwikiGenerateLinks lacks -nargs=? (upstream optional rel-path arg) → E488. - NuwikiGenerateTags missing (Vimwiki form + NuwikiGenerateTagLinks exist) — :Vimwiki*↔:Nuwiki* asymmetry. Refinements to existing P3 items: - TableAlignQ/W: also bare vs upstream -nargs=? (E488 with an arg). - VimwikiSearch/VWS: also -nargs=1 vs upstream -nargs=*. - diary -count: VimwikiDiaryIndex is an additional instance to fold in. - color_dic: note the empty-default vs upstream-palette divergence (doc-accurate, not a doc↔code mismatch) next to color_tag_template. Mappings + configs audits: clean — no new gaps, all recent work consistent, subgroup descriptions match code. Tally now 30 done / 27 open (all P3). Co-Authored-By: Claude Opus 4.8 (1M context) --- development/vimwiki-gap.md | 31 +++++++++++++++++++++++++++++-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/development/vimwiki-gap.md b/development/vimwiki-gap.md index d0efdb1..2c1eca9 100644 --- a/development/vimwiki-gap.md +++ b/development/vimwiki-gap.md @@ -176,7 +176,9 @@ fix site. - [ ] `VimwikiShowVersion` — print version (trivial). _Fix:_ `plugin/nuwiki.vim`. - [ ] `VimwikiReturn` — no Ex-command (mapping-driven only). _Fix:_ `ftplugin/vimwiki.vim`. - [ ] `VimwikiTableAlignQ` vs `AlignW` collapsed to one `table_align` — `gqq` - (align) vs `gww` (align w/o resize) distinction lost. + (align) vs `gww` (align w/o resize) distinction lost. _(Re-audit 2026-05-31: + also note the attr differs — both are defined bare in all four contexts vs + upstream's `-nargs=?`, so `:VimwikiTableAlignQ 2` raises E488.)_ - [x] `VimwikiTable` was `-nargs=1` vs upstream `-nargs=*` (couldn't pass cols+rows). _Fix:_ all four defs (Vim+Neovim × Vimwiki+Nuwiki) are now `-nargs=*` and forward `` to `table_insert` (which already parsed @@ -223,6 +225,25 @@ fix site. wiki (via `wikis_snapshot()`) instead of just the current one. `-bang` added to all four command defs. - [ ] `:VimwikiSearch` / `VWS` uses `lvimgrep`, not vimwiki's search engine. + _(Re-audit 2026-05-31: also `-nargs=1` in all four contexts vs upstream + `-nargs=*`.)_ +- [ ] **`VimwikiChangeSymbolTo` / `VimwikiListChangeSymbolI` lack `-range`** + _(new, 2026-05-31 re-audit)_ — upstream both carry `-range -nargs=1`; nuwiki + defines them `-nargs=1` only (both branches), so `:'<,'>VimwikiChangeSymbolTo X` + over a visual selection raises `E481: No range allowed`. (Internally + consistent across nuwiki's four contexts; purely an upstream-parity gap.) + `ChangeSymbolInListTo` is correctly range-less. _Fix:_ add `-range` + a + `*_range` loop, mirroring the `ToggleListItem`/`IncrementListItem` range work. +- [ ] **`VimwikiGenerateLinks` lacks `-nargs=?`** _(new, 2026-05-31 re-audit)_ — + upstream takes an optional rel-path arg (`-nargs=?`); nuwiki defines it bare in + all four contexts, so `:VimwikiGenerateLinks foo` raises `E488`. Low impact + (the arg is rarely used). _Fix:_ `ftplugin/vimwiki.vim` + thread an optional + path into `links_generate`. +- [ ] **`NuwikiGenerateTags` missing** _(new, 2026-05-31 re-audit)_ — the + `:Nuwiki*` surface lacks a `GenerateTags` alias although `:VimwikiGenerateTags` + exists (both branches) and `NuwikiGenerateTagLinks` (same handler) is present. + Internal `:Vimwiki*`↔`:Nuwiki*` asymmetry; trivial. _Fix:_ add the two + `NuwikiGenerateTags` defs (Vim + Neovim) mirroring `VimwikiGenerateTags`. - [ ] `VimwikiIndex` family is buffer-local in nuwiki (upstream defines globally in `plugin/`); only `:…UISelect` is a global entry point. - [x] **`VimwikiColorize` / `NuwikiColorize` drop their argument in the Neovim @@ -279,7 +300,8 @@ fix site. diary commands (accept an optional `wiki` selector). _(The `Index`/`TabIndex` half is done: all four defs now use upstream's `-count=0` instead of bare `-count`; `wiki_index`/`wiki_tab_index` already map the count to the wiki - number.)_ + number.)_ _(Re-audit 2026-05-31: `VimwikiDiaryIndex` is an additional instance + — bare in all four contexts vs upstream `-count=0` — fold it into this fix.)_ - [x] **`-complete=` specs** _(new; done 2026-05-31 command-attribute pass)_ — upstream attaches command-line completion to several commands; nuwiki had none, so `` at the `:` line never completed page / tag / colour names. @@ -331,6 +353,11 @@ fix site. - [ ] `bullet_types` / `cycle_bullets` — custom bullet glyphs + wrap-around. - [ ] `commentstring` (`'%%%s'`) — comment toggling/text-objects. - [ ] `color_tag_template` — `color_dic` present; template regex missing. + Related divergence _(2026-05-31 config re-audit)_: nuwiki's `color_dic` + defaults to **empty** while upstream ships a populated palette + (`default`/`red`/…). Documented accurately on the nuwiki side (so it's not a + doc↔code mismatch); the renderer falls back to `class="color-"`. Decide + whether to seed a default palette or keep empty-by-design. - [ ] `rss_max_items` / `rss_name` — `:Rss` output hardcoded. _Fix:_ `HtmlConfig`. - [ ] **RSS feed structure fidelity** _(new, 2026-05-31 base_url audit)_ — nuwiki's `write_rss` is intentionally minimal (title/link/guid). Upstream