docs(gap): expand audit findings
Reframe diary_start_week_day as a wrongly-removed client-side concern that matters for parity (non-Monday users lose the upstream option). Add four P3 command-divergence rows (Neovim VimwikiColorize arg-drop, TableMoveColumn backing-name split, NuwikiTabIndex missing -count, ToggleListItem/Increment/Decrement missing -range) and a P3 mappings row for the gLH/gLL/gLR case-variant aliases. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
@@ -88,9 +88,13 @@ fix site.
|
||||
`:VimwikiBaddLink`). _Fix:_ `lua/nuwiki/keymaps.lua`, `ftplugin/vimwiki.vim`.
|
||||
- [ ] **`diary_caption_level` default divergence** — nuwiki `1` vs vimwiki `0`.
|
||||
_Fix:_ `config.rs:291` (and defaults in `lua/nuwiki/config.lua`).
|
||||
- [ ] **`diary_start_week_day`** — deliberately removed in `c63ec67`; the weekly
|
||||
diary is fixed to ISO-Monday. Default matches upstream, but non-Monday users
|
||||
lose it. _Fix:_ `config.rs` + `crates/nuwiki-core/src/date.rs`.
|
||||
- [ ] **`diary_start_week_day`** — **wrongly removed** in `c63ec67`. The removal
|
||||
treated it as a server concern and hardwired the weekly diary to ISO-Monday
|
||||
(`crates/nuwiki-core/src/date.rs` `monday_of_iso_week`), but choosing which
|
||||
weekday the diary week begins on is a **client-side concern** and it **matters
|
||||
for parity** — non-Monday users lose the upstream option entirely. _Fix:_
|
||||
restore the config key client-side (`lua/nuwiki/config.lua`) and thread the
|
||||
week-start through to the diary date logic instead of hardcoding Monday.
|
||||
|
||||
## P3 — Niche / low impact
|
||||
|
||||
@@ -106,6 +110,21 @@ fix site.
|
||||
- [ ] `:VimwikiSearch` / `VWS` uses `lvimgrep`, not vimwiki's search engine.
|
||||
- [ ] `VimwikiIndex` family is buffer-local in nuwiki (upstream defines globally
|
||||
in `plugin/`); only `:…UISelect` is a global entry point.
|
||||
- [ ] **`VimwikiColorize` / `NuwikiColorize` drop their argument in the Neovim
|
||||
branch** — both are `-nargs=1`, but the Neovim defs call `colorize()` with no
|
||||
`<q-args>` (`ftplugin/vimwiki.vim:445,517`) while the Vim branch passes it
|
||||
(`:106,177`). The color name is silently ignored under Neovim (real bug, not
|
||||
just parity). _Fix:_ `ftplugin/vimwiki.vim` Neovim branch.
|
||||
- [ ] **`VimwikiTableMoveColumn{Left,Right}` dispatch to different backing names
|
||||
per client** — Vim branch → `table_move_left/right`; Neovim branch →
|
||||
`table_move_column_left/right`. Harmless today (each name exists in its own
|
||||
impl) but a divergence to converge.
|
||||
- [ ] **`NuwikiTabIndex` lacks `-count` in the Neovim branch** (`:452`) while its
|
||||
siblings (`VimwikiTabIndex`, `NuwikiIndex`, and the Vim-branch `NuwikiTabIndex`)
|
||||
all carry it — `vim.v.count` is still read, so a count is honored inconsistently.
|
||||
- [ ] **`VimwikiToggleListItem` / `Increment` / `DecrementListItem` lack
|
||||
`-range`** (both branches) vs upstream's `-range` (`:350`) — no visual-range
|
||||
checkbox toggle / symbol cycle.
|
||||
|
||||
### Config
|
||||
- [ ] `auto_header` — auto H1-from-filename on new page (server-side).
|
||||
@@ -125,6 +144,11 @@ fix site.
|
||||
### Mappings
|
||||
- [ ] Visual `<CR>` normalize-link (visual `+` covers the same intent).
|
||||
- [ ] Insert `<S-CR>` multiline list item.
|
||||
- [ ] `gLH` / `gLL` / `gLR` — upstream binds these as case-variant **aliases**
|
||||
of `gLh` / `gLl` / `gLr` (same actions: dedent / indent whole item, renumber
|
||||
all lists; upstream `ftplugin/vimwiki.vim:553,555,561`). nuwiki has the
|
||||
lowercase forms but not the uppercase-suffix aliases. Cosmetic — same effect,
|
||||
redundant keys.
|
||||
|
||||
---
|
||||
|
||||
|
||||
Reference in New Issue
Block a user