gffranco
3865b8bf0e
Closes the actionable fifth-pass findings (gap doc updated): - VimwikiGoto / NuwikiGoto: -nargs=1 -> -nargs=* in all four defs. Was a real bug — `:VimwikiGoto` raised E471, `:VimwikiGoto My Page` raised E488, and the handler's empty-arg prompt fallback was unreachable. Both clients already prompt on empty, so -nargs=* (keeping -complete=pages) restores upstream behavior. - autowriteall (upstream default ON): while a wiki buffer is current, mirror Vim's global 'autowriteall' (auto-save on page switch / :make), restoring the prior value on leave. Neovim via ftplugin.lua setup_autowriteall (BufEnter/BufLeave) gated by the `autowriteall` setup option; Vim via the NuwikiAutoWriteAll augroup gated by g:nuwiki_autowriteall. - table_auto_fmt (upstream default ON): re-align the table under the cursor on InsertLeave. Both clients, gated by `table_auto_fmt` / g:nuwiki_table_auto_fmt, guarded on the cursor line containing `|` before the async table_align. Also logged (no code): VimwikiRenameFile missing -nargs=? (subsumed by the LSP-rename divergence), table_reduce_last_col, user_htmls, hl_headers/ hl_cb_checked, and a commentstring value-mismatch note. Mappings audit clean. The Neovim harness disables table_auto_fmt in setup (its async re-align would perturb the deterministic table-nav keystroke cases); its wiring is verified on a throwaway scratch buffer instead. Docs (README + doc/nuwiki.txt) updated. Tests: cmd.VimwikiGoto_accepts_multiword, config.autowriteall_applied, config.table_auto_fmt_autocmd. Neovim 293, Vim 285/18/21 pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
78 lines
2.7 KiB
Bash
Executable File
78 lines
2.7 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
#
|
|
# development/tests/test-keymaps.sh — drive development/tests/test-keymaps.lua under
|
|
# headless Neovim and report pass/fail per buffer-local keymap.
|
|
#
|
|
# The Lua harness needs a real LSP attachment (most keymaps dispatch
|
|
# `workspace/executeCommand`), so we:
|
|
# 1. ensure `bin/nuwiki-ls` is built (release),
|
|
# 2. spin up a scratch wiki under a temp dir,
|
|
# 3. invoke `nvim --headless` with a minimal init that loads the
|
|
# plugin + calls `setup()`, then sources the harness Lua.
|
|
#
|
|
# Exit code mirrors the harness: 0 on green, 1 on any failure.
|
|
|
|
set -euo pipefail
|
|
|
|
REPO_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd)"
|
|
TMP="$(mktemp -d -t nuwiki-keymap-test-XXXXXX)"
|
|
trap 'rm -rf "$TMP"' EXIT
|
|
|
|
log() { printf '\033[1;34m[keymap-test]\033[0m %s\n' "$*"; }
|
|
|
|
# Always rebuild the LSP binary so harness runs against current sources.
|
|
# A previous version only built when the symlink was missing, which let
|
|
# stale binaries pass tests against unrelated code — incremental cargo
|
|
# build is fast, so just always run it.
|
|
BIN="$REPO_ROOT/bin/nuwiki-ls"
|
|
log 'building nuwiki-ls (release, incremental)…'
|
|
cargo build --release -p nuwiki-ls --manifest-path "$REPO_ROOT/Cargo.toml" >/dev/null
|
|
mkdir -p "$REPO_ROOT/bin"
|
|
ln -sf "$REPO_ROOT/target/release/nuwiki-ls" "$BIN"
|
|
|
|
mkdir -p "$TMP/wiki"
|
|
echo "= seed =" > "$TMP/wiki/index.wiki"
|
|
|
|
INIT="$TMP/init.lua"
|
|
cat > "$INIT" <<EOF
|
|
-- Keep the harness self-contained; no plugin manager required.
|
|
vim.opt.runtimepath:prepend('$REPO_ROOT')
|
|
vim.g.nuwiki_binary_path = '$BIN'
|
|
-- Enable the opt-in mouse mappings so the harness can assert the full
|
|
-- documented mapping surface (doc §6 mouse group). table_auto_fmt is off here
|
|
-- so its async on-InsertLeave re-align doesn't perturb the deterministic
|
|
-- table-nav keystroke cases (its wiring is verified on a scratch buffer).
|
|
require('nuwiki').setup({
|
|
wiki_root = '$TMP/wiki',
|
|
mappings = { mouse = true },
|
|
table_auto_fmt = false,
|
|
})
|
|
EOF
|
|
|
|
RESULTS="$TMP/results.txt"
|
|
log "running harness…"
|
|
|
|
# `nvim --headless -u init.lua FILE +luafile …` — the harness's
|
|
# `vim.defer_fn` lets the LSP attach before tests fire, then writes
|
|
# the results file and exits. Output path is plumbed through env.
|
|
# Wrapped in `timeout` so a hung LSP / harness fails fast instead of
|
|
# stalling CI runners indefinitely.
|
|
NUWIKI_KEYMAP_RESULTS="$RESULTS" \
|
|
timeout 60 nvim --clean -u "$INIT" --headless "$TMP/wiki/index.wiki" \
|
|
-c "luafile $REPO_ROOT/development/tests/test-keymaps.lua" \
|
|
>"$TMP/nvim.log" 2>&1 || true
|
|
|
|
if [[ ! -f "$RESULTS" ]]; then
|
|
echo 'keymap test harness produced no output' >&2
|
|
echo '--- nvim log ---' >&2
|
|
cat "$TMP/nvim.log" >&2 || true
|
|
exit 1
|
|
fi
|
|
|
|
cat "$RESULTS"
|
|
|
|
if grep -qE '^SUMMARY: [0-9]+ passed, 0 failed' "$RESULTS"; then
|
|
exit 0
|
|
fi
|
|
exit 1
|